fix: add types exports declaration for ./locales/* #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue that prevented Zod from being build and served through the Skypack CDN. Namely, Skypack was unable to resolve the declaration file `lib/locales/en.d.ts` because it was not exposed by the `exports` definition in `package.json`.
✅ Deploy Preview for guileless-rolypoly-866f8a ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Aug 10, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2698 #1461
This change fixes an issue that prevented Zod from being build and served through the Skypack CDN. Namely, Skypack was unable to resolve the declaration file
lib/locales/en.d.tsbecause it was not exposed by thepackage.json#exportsdeclaration.I was able to verify this fix by publishing this branch to NPM (link) and comparing the result of the following in a Chrome console:
There was also a hint from other issues that Zod v3.18.x worked through Skypack but 3.19.0 did not. The latter is where the malformed exports declaration for
./locales/*was introduced.